]> www.infradead.org Git - users/jedix/linux-maple.git/commit
serial: 8250: Do not set UART_LSR_THRE in @read_status_mask
authorJohn Ogness <john.ogness@linutronix.de>
Mon, 16 Dec 2024 17:12:42 +0000 (18:18 +0106)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Dec 2024 17:59:59 +0000 (18:59 +0100)
commit9d31746b5385c3f760746f7b2d63b702e2f80de0
treea347cf983395279881be69397eb0c716a0636d68
parentc9f49e3e45fccae1841ae61bc5187fef18419ce6
serial: 8250: Do not set UART_LSR_THRE in @read_status_mask

Since Linux 2.1.8 @read_status_mask is no longer used as a
general control of which bits are used from the LSR register.
Instead it has become an additional mask applied to
@ignore_status_mask. Since UART_LSR_THRE is never set for
@ignore_status_mask, it serves no purpose to set it for
@read_status_mask. In fact, it propagates the misconception
that @read_status_mask can be used as a general mask for LSR
bits.

Do not set UART_LSR_THRE for @read_status_mask.

Signed-off-by: John Ogness <john.ogness@linutronix.de>
Link: https://lore.kernel.org/r/20241216171244.12783-3-john.ogness@linutronix.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_omap.c
drivers/tty/serial/8250/8250_port.c