]> www.infradead.org Git - users/jedix/linux-maple.git/commit
xfrm: Add error handling when nla_put_u32() returns an error
authorEverest K.C <everestkc@everestkc.com.np>
Tue, 12 Nov 2024 23:36:06 +0000 (16:36 -0700)
committerSteffen Klassert <steffen.klassert@secunet.com>
Thu, 14 Nov 2024 07:23:15 +0000 (08:23 +0100)
commit9d287e70c51f1c141ac588add261ed2efdd6fc6b
tree6c996928303226e6527da828151f282bf2f87722
parentaf2c4fa559725ee583fe0689cddca58ef95ff0d5
xfrm: Add error handling when nla_put_u32() returns an error

Error handling is missing when call to nla_put_u32() fails.
Handle the error when the call to nla_put_u32() returns an error.

The error was reported by Coverity Scan.
Report:
CID 1601525: (#1 of 1): Unused value (UNUSED_VALUE)
returned_value: Assigning value from nla_put_u32(skb, XFRMA_SA_PCPU, x->pcpu_num)
to err here, but that stored value is overwritten before it can be used

Fixes: 1ddf9916ac09 ("xfrm: Add support for per cpu xfrm state handling.")
Signed-off-by: Everest K.C. <everestkc@everestkc.com.np>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/xfrm/xfrm_user.c