]> www.infradead.org Git - users/jedix/linux-maple.git/commit
arm64: dts: rockchip: increase gmac rx_delay on rk3399-puma
authorJakob Unterwurzacher <jakobunt@gmail.com>
Fri, 13 Dec 2024 09:54:58 +0000 (10:54 +0100)
committerHeiko Stuebner <heiko@sntech.de>
Thu, 9 Jan 2025 15:21:46 +0000 (16:21 +0100)
commit9d241b06802c6c2176ae7aa4f9f17f8a577ed337
tree8019aed61babe9d79ee2c3993a3d29a4f69af0b9
parent3ca11da6e8a7b578c28dcecc31237791955c62fc
arm64: dts: rockchip: increase gmac rx_delay on rk3399-puma

During mass manufacturing, we noticed the mmc_rx_crc_error counter,
as reported by "ethtool -S eth0 | grep mmc_rx_crc_error", to increase
above zero during nuttcp speedtests. Most of the time, this did not
affect the achieved speed, but it prompted this investigation.

Cycling through the rx_delay range on six boards (see table below) of
various ages shows that there is a large good region from 0x12 to 0x35
where we see zero crc errors on all tested boards.

The old rx_delay value (0x10) seems to have always been on the edge for
the KSZ9031RNX that is usually placed on Puma.

Choose "rx_delay = 0x23" to put us smack in the middle of the good
region. This works fine as well with the KSZ9131RNX PHY that was used
for a small number of boards during the COVID chip shortages.

Board S/N        PHY        rx_delay good region
---------        ---        --------------------
Puma TT0069903   KSZ9031RNX 0x11 0x35
Puma TT0157733   KSZ9031RNX 0x11 0x35
Puma TT0681551   KSZ9031RNX 0x12 0x37
Puma TT0681156   KSZ9031RNX 0x10 0x38
Puma 17496030079 KSZ9031RNX 0x10 0x37 (Puma v1.2 from 2017)
Puma TT0681720   KSZ9131RNX 0x02 0x39 (alternative PHY used in very few boards)

Intersection of good regions = 0x12 0x35
Middle of good region = 0x23

Fixes: 2c66fc34e945 ("arm64: dts: rockchip: add RK3399-Q7 (Puma) SoM")
Cc: stable@vger.kernel.org
Reviewed-by: Quentin Schulz <quentin.schulz@cherry.de>
Tested-by: Quentin Schulz <quentin.schulz@cherry.de> # Puma v2.1 and v2.3 with KSZ9031
Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@cherry.de>
Link: https://lore.kernel.org/r/20241213-puma_rx_delay-v4-1-8e8e11cc6ed7@cherry.de
Signed-off-by: Heiko Stuebner <heiko@sntech.de>
arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi