]> www.infradead.org Git - users/willy/pagecache.git/commit
net: hsr: fix hsr_init_sk() vs network/transport headers.
authorEric Dumazet <edumazet@google.com>
Fri, 22 Nov 2024 17:13:43 +0000 (17:13 +0000)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 26 Nov 2024 11:45:53 +0000 (12:45 +0100)
commit9cfb5e7f0ded2bfaabc270ceb5f91d13f0e805b9
tree7d4a44bacbbddb6f4c5fd6e8631e97629d7b7289
parent05cff25eb32ce375a59431afe47a6fe0b9548b78
net: hsr: fix hsr_init_sk() vs network/transport headers.

Following sequence in hsr_init_sk() is invalid :

    skb_reset_mac_header(skb);
    skb_reset_mac_len(skb);
    skb_reset_network_header(skb);
    skb_reset_transport_header(skb);

It is invalid because skb_reset_mac_len() needs the correct
network header, which should be after the mac header.

This patch moves the skb_reset_network_header()
and skb_reset_transport_header() before
the call to dev_hard_header().

As a result skb->mac_len is no longer set to a value
close to 65535.

Fixes: 48b491a5cc74 ("net: hsr: fix mac_len checks")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: George McCollister <george.mccollister@gmail.com>
Link: https://patch.msgid.link/20241122171343.897551-1-edumazet@google.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/hsr/hsr_device.c