]> www.infradead.org Git - users/jedix/linux-maple.git/commit
powerpc/pseries/msi: Avoid reading PCI device registers in reduced power states
authorGautam Menghani <gautam@linux.ibm.com>
Wed, 5 Mar 2025 09:02:36 +0000 (14:32 +0530)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Tue, 29 Apr 2025 05:37:45 +0000 (11:07 +0530)
commit9cc0eafd28c7faef300822992bb08d79cab2a36c
treefca3877ac9d1467951b815e8e9ebe2e7a67e23ff
parent59ba025948be2a92e8bc9ae1cbdaf197660bd508
powerpc/pseries/msi: Avoid reading PCI device registers in reduced power states

When a system is being suspended to RAM, the PCI devices are also
suspended and the PPC code ends up calling pseries_msi_compose_msg() and
this triggers the BUG_ON() in __pci_read_msi_msg() because the device at
this point is in reduced power state. In reduced power state, the memory
mapped registers of the PCI device are not accessible.

To replicate the bug:
1. Make sure deep sleep is selected
# cat /sys/power/mem_sleep
s2idle [deep]

2. Make sure console is not suspended (so that dmesg logs are visible)
echo N > /sys/module/printk/parameters/console_suspend

3. Suspend the system
echo mem > /sys/power/state

To fix this behaviour, read the cached msi message of the device when the
device is not in PCI_D0 power state instead of touching the hardware.

Fixes: a5f3d2c17b07 ("powerpc/pseries/pci: Add MSI domains")
Cc: stable@vger.kernel.org # v5.15+
Signed-off-by: Gautam Menghani <gautam@linux.ibm.com>
Tested-by: Venkat Rao Bagalkote <venkat88@linux.ibm.com>
Reviewed-by: Vaibhav Jain <vaibhav@linux.ibm.com>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20250305090237.294633-1-gautam@linux.ibm.com
arch/powerpc/platforms/pseries/msi.c