]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/bridge: tc358768: Stop disabling when failing to enable
authorMaxime Ripard <mripard@kernel.org>
Thu, 13 Mar 2025 12:00:08 +0000 (13:00 +0100)
committerMaxime Ripard <mripard@kernel.org>
Thu, 20 Mar 2025 13:45:51 +0000 (14:45 +0100)
commit9c77154b71ad936227d0c407835854604c532700
tree5bac55e95916f6876610a33bf02bbf540539e65a
parentae875180318a51b2812295e8948162108f5e46ef
drm/bridge: tc358768: Stop disabling when failing to enable

The tc358768 bridge driver, if enabling it fails, tries to disable it.
This is pretty uncommon in bridge drivers, and also stands in the way
for further reworks.

Worse, since pre_enable and enable aren't expected to fail, disable and
post_disable might be called twice: once to handle the failure, and once
to actually disable the bridge.

Since post_disable uses regulators and clocks, this would lead to enable
count imbalances.

In order to prevent that imbalance, and to allow further reworks, let's
drop the calls to disable and post_disable, but keep the warning to let
users know about what's going on.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20250313-bridge-connector-v6-14-511c54a604fb@kernel.org
Signed-off-by: Maxime Ripard <mripard@kernel.org>
drivers/gpu/drm/bridge/tc358768.c