]> www.infradead.org Git - users/dwmw2/linux.git/commit
cpufreq/amd-pstate: Remove warning for X86_FEATURE_CPPC on certain Zen models
authorGautham R. Shenoy <gautham.shenoy@amd.com>
Wed, 28 Aug 2024 10:10:35 +0000 (15:40 +0530)
committerMario Limonciello <mario.limonciello@amd.com>
Wed, 28 Aug 2024 15:15:00 +0000 (10:15 -0500)
commit9c68a3b03e8109f3917fd35f39043499897d4a79
tree61600e3d99b7a569305fd6e94f7f808e00bfccca
parent9983a9cd4d429dc9ca01770083c4c1f366214b65
cpufreq/amd-pstate: Remove warning for X86_FEATURE_CPPC on certain Zen models

commit bff7d13c190a ("cpufreq: amd-pstate: add debug message while
CPPC is supported and disabled by SBIOS") issues a warning on plaforms
where the X86_FEATURE_CPPC is expected to be enabled, but is not due
to it being disabled in the BIOS.

This feature bit corresponds to CPUID 0x80000008.ebx[27] which is a
reserved bit on the Zen1 processors and a reserved bit on Zen2 based
models 0x70-0x7F, and is expected to be cleared on these
platforms. Thus printing the warning message for these models when
X86_FEATURE_CPPC is unavailable is incorrect. Fix this.

Modify some of the comments, and use switch-case for model range
checking for improved readability while at it.

Fixes: bff7d13c190a ("cpufreq: amd-pstate: add debug message while CPPC is supported and disabled by SBIOS")
Cc: Xiaojian Du <xiaojian.du@amd.com>
Reported-by: David Wang <00107082@163.com>
Closes: https://lore.kernel.org/lkml/20240730140111.4491-1-00107082@163.com/
Signed-off-by: Gautham R. Shenoy <gautham.shenoy@amd.com>
Acked-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
drivers/cpufreq/amd-pstate.c