]> www.infradead.org Git - users/jedix/linux-maple.git/commit
nvmem: rmem: make ->reg_read() straight forward code
authorThéo Lebrun <theo.lebrun@bootlin.com>
Mon, 30 Dec 2024 14:30:28 +0000 (14:30 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 30 Dec 2024 14:35:59 +0000 (15:35 +0100)
commit9c1d9de52b64c353bd387f7fc264bc747a40e1f9
tree9894a784809767e2af2d677d1504f6316bb46be4
parent6fdbc7b9aa20b1db47d13a5f2a4d31fb2f8f3822
nvmem: rmem: make ->reg_read() straight forward code

memory_read_from_buffer() is a weird choice; it:
 - is made for iteration with ppos a pointer.
 - does futile error checking in our case.
 - does NOT ensure we read exactly N bytes.

Replace it by:
1. A check that (offset + bytes) lands inside the region and,
2. a plain memcpy().

Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20241230143035.265518-5-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/nvmem/rmem.c