]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ovl: Copy up underlying inode's ->i_mode to overlay inode
authorVivek Goyal <vgoyal@redhat.com>
Fri, 1 Jul 2016 20:34:25 +0000 (16:34 -0400)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:22:05 +0000 (17:22 -0500)
commit9bfe293f21fbb95e9e37873bb54ebf23ad013647
tree09f79cfac2ec2e4935b5c321e547de22c4630be9
parentd8aeb46003e16c2fb89123b4222c1529cf824a5b
ovl: Copy up underlying inode's ->i_mode to overlay inode

Orabug: 25308103

[ Upstream commit 07a2daab49c549a37b5b744cbebb6e3f445f12bc ]

Right now when a new overlay inode is created, we initialize overlay
inode's ->i_mode from underlying inode ->i_mode but we retain only
file type bits (S_IFMT) and discard permission bits.

This patch changes it and retains permission bits too. This should allow
overlay to do permission checks on overlay inode itself in task context.

[SzM] It also fixes clearing suid/sgid bits on write.

Signed-off-by: Vivek Goyal <vgoyal@redhat.com>
Reported-by: Eryu Guan <eguan@redhat.com>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
Fixes: 4bacc9c9234c ("overlayfs: Make f_path always point to the overlay and f_inode to the underlay")
Cc: <stable@vger.kernel.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
(cherry picked from commit 31534f8fead7e0dff7ba68bd5dfcf6a9dfe908bc)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
fs/overlayfs/inode.c
fs/overlayfs/overlayfs.h