]> www.infradead.org Git - users/jedix/linux-maple.git/commit
media: sun4i_csi: Don't use v4l2_subdev_link_validate() for video device
authorLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Tue, 18 Jun 2024 23:46:16 +0000 (02:46 +0300)
committerLaurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Mon, 26 Aug 2024 13:36:14 +0000 (16:36 +0300)
commit9bde4f7caf38df94257d2483e89f371b1a530e9a
treeae6b808ada5e53cbdf6178e71b7fcf08714d8770
parent2dc5d5d401f5c6cecd97800ffef82e8d17d228f0
media: sun4i_csi: Don't use v4l2_subdev_link_validate() for video device

The v4l2_subdev_link_validate() function is a helper designed to
validate links whose sink is a subdev. When called on a link whose sink
is a video device, it only prints a warning and returns. Its usage in
the sun4i_csi driver is wrong, leaving the link from the sub4i_csi
subdev to the capture video device unvalidated.

Planned improvements to the v4l2_subdev_link_validate() function will
turn the warning into an error, breaking the sun4i_csi driver. As an
interim measure, move the warning to the sun4i_csi driver in a custom
validation handler, and drop the call to the helper.

Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Acked-by: Chen-Yu Tsai <wens@csie.org>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen+renesas@ideasonboard.com>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
drivers/media/platform/sunxi/sun4i-csi/sun4i_csi.c