]> www.infradead.org Git - users/willy/linux.git/commit
mmc: meson-gx: also check SD_IO_RW_EXTENDED for scatterlist size alignment
authorNeil Armstrong <narmstrong@baylibre.com>
Mon, 26 Apr 2021 17:55:59 +0000 (19:55 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 10 May 2021 12:29:39 +0000 (14:29 +0200)
commit9b81354d7ebc1fd17f666a168dcabf27dae290bd
tree0236eae1ea67378247912a6777c3352129660253
parentcabb1bb60e88ccaaa122ba01862403cd44e8e8f8
mmc: meson-gx: also check SD_IO_RW_EXTENDED for scatterlist size alignment

The brcmfmac driver can generate a scatterlist from a skb with each packets
not aligned to the block size. This is not supported by the Amlogic Descriptor
dma engine where each descriptor must match a multiple of the block size.

The sg list is valid, since the sum of the sg buffers is a multiple of the
block size, but we must discard those when in SD_IO_RW_EXTENDED mode since
SDIO block mode can be used under the hood even with data->blocks == 1.

Those transfers are very rare, thus can be replaced by a bounce buffer
without real performance loss.

Fixes: 7412dee9f1fd ("mmc: meson-gx: replace WARN_ONCE with dev_warn_once about scatterlist size alignment in block mode")
Cc: stable@vger.kernel.org
Reported-by: Christian Hewitt <christianshewitt@gmail.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Link: https://lore.kernel.org/r/20210426175559.3110575-2-narmstrong@baylibre.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/meson-gx-mmc.c