]> www.infradead.org Git - users/dwmw2/linux.git/commit
checkpatch: add ethtool_sprintf rules
authorjustinstitt@google.com <justinstitt@google.com>
Wed, 6 Dec 2023 23:16:11 +0000 (23:16 +0000)
committerDavid S. Miller <davem@davemloft.net>
Fri, 8 Dec 2023 10:56:25 +0000 (10:56 +0000)
commit9b5f621cea6eff2f75b851c6c62cefbdb1673c44
treed835f307d5e658665dfe69499b90e19e80cd04a2
parent2a48c635fd9a48699805bbfeee1e4b94b8fe819d
checkpatch: add ethtool_sprintf rules

Add some warnings for using ethtool_sprintf() where a simple
ethtool_puts() would suffice.

The two cases are:

1) Use ethtool_sprintf() with just two arguments:
|       ethtool_sprintf(&data, driver[i].name);
or
2) Use ethtool_sprintf() with a standalone "%s" fmt string:
|       ethtool_sprintf(&data, "%s", driver[i].name);

The former may cause -Wformat-security warnings while the latter is just
not preferred. Both are safely in the category of warnings, not errors.

Signed-off-by: Justin Stitt <justinstitt@google.com>
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
scripts/checkpatch.pl