]> www.infradead.org Git - nvme.git/commit
block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()
authorSu Hui <suhui@nfschina.com>
Tue, 11 Jun 2024 07:37:00 +0000 (15:37 +0800)
committerJens Axboe <axboe@kernel.dk>
Wed, 12 Jun 2024 16:53:20 +0000 (10:53 -0600)
commit9b1ebce6a1fded90d4a1c6c57dc6262dac4c4c14
tree6f6c1ee32b4768b2e58fa882daace7fc80486ef3
parent27d024235bdb16af917809d33916392452c3ac85
block: sed-opal: avoid possible wrong address reference in read_sed_opal_key()

Clang static checker (scan-build) warning:
block/sed-opal.c:line 317, column 3
Value stored to 'ret' is never read.

Fix this problem by returning the error code when keyring_search() failed.
Otherwise, 'key' will have a wrong value when 'kerf' stores the error code.

Fixes: 3bfeb6125664 ("block: sed-opal: keyring support for SED keys")
Signed-off-by: Su Hui <suhui@nfschina.com>
Link: https://lore.kernel.org/r/20240611073659.429582-1-suhui@nfschina.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/sed-opal.c