]> www.infradead.org Git - users/jedix/linux-maple.git/commit
net: ti: icssg-prueth: Fix clearing of IEP_CMP_CFG registers during iep_init
authorMeghana Malladi <m-malladi@ti.com>
Mon, 23 Dec 2024 15:15:50 +0000 (20:45 +0530)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Jan 2025 11:54:06 +0000 (11:54 +0000)
commit9b115361248dc6cce182a2dc030c1c70b0a9639e
treece41100fcfe8cb84374d6457c6bd731cedd3f74c
parent9facce84f4062f782ebde18daa7006a23d40b607
net: ti: icssg-prueth: Fix clearing of IEP_CMP_CFG registers during iep_init

When ICSSG interfaces are brought down and brought up again, the
pru cores are shut down and booted again, flushing out all the memories
and start again in a clean state. Hence it is expected that the
IEP_CMP_CFG register needs to be flushed during iep_init() to ensure
that the existing residual configuration doesn't cause any unusual
behavior. If the register is not cleared, existing IEP_CMP_CFG set for
CMP1 will result in SYNC0_OUT signal based on the SYNC_OUT register values.

After bringing the interface up, calling PPS enable doesn't work as
the driver believes PPS is already enabled, (iep->pps_enabled is not
cleared during interface bring down) and driver will just return true
even though there is no signal. Fix this by disabling pps and perout.

Fixes: c1e0230eeaab ("net: ti: icss-iep: Add IEP driver")
Signed-off-by: Meghana Malladi <m-malladi@ti.com>
Reviewed-by: Roger Quadros <rogerq@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/ti/icssg/icss_iep.c