]> www.infradead.org Git - users/dwmw2/qemu.git/commit
migration/multifd: Duplicate the fd for the outgoing_args
authorFabiano Rosas <farosas@suse.de>
Fri, 15 Mar 2024 03:20:39 +0000 (00:20 -0300)
committerPeter Xu <peterx@redhat.com>
Fri, 15 Mar 2024 15:26:33 +0000 (11:26 -0400)
commit9adfb308c1513562d6acec02aa780c5ef9b0193d
treeed407ce31bbdb3cb07b0276cefa9adcc10c0a4e5
parent73f6f9a12fb4a3afe01e18690ebd6a6e4283c1a6
migration/multifd: Duplicate the fd for the outgoing_args

We currently store the file descriptor used during the main outgoing
channel creation to use it again when creating the multifd
channels.

Since this fd is used for the first iochannel, there's risk that the
QIOChannel gets freed and the fd closed while outgoing_args.fd still
has it available. This could lead to an fd-reuse bug.

Duplicate the outgoing_args fd to avoid this issue.

Suggested-by: Peter Xu <peterx@redhat.com>
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Link: https://lore.kernel.org/r/20240315032040.7974-3-farosas@suse.de
Signed-off-by: Peter Xu <peterx@redhat.com>
migration/fd.c