]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: fix crash when config small gso_max_size/gso_ipv4_max_size
authorWang Liang <wangliang74@huawei.com>
Wed, 23 Oct 2024 03:52:13 +0000 (11:52 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 29 Oct 2024 23:18:23 +0000 (16:18 -0700)
commit9ab5cf19fb0e4680f95e506d6c544259bf1111c4
tree7cdd0b7a6ea7d3b802d6b47a2b8368ff68118dae
parent6b3f18a76be6bbd237c7594cf0bf2912b68084fe
net: fix crash when config small gso_max_size/gso_ipv4_max_size

Config a small gso_max_size/gso_ipv4_max_size will lead to an underflow
in sk_dst_gso_max_size(), which may trigger a BUG_ON crash,
because sk->sk_gso_max_size would be much bigger than device limits.
Call Trace:
tcp_write_xmit
    tso_segs = tcp_init_tso_segs(skb, mss_now);
        tcp_set_skb_tso_segs
            tcp_skb_pcount_set
                // skb->len = 524288, mss_now = 8
                // u16 tso_segs = 524288/8 = 65535 -> 0
                tso_segs = DIV_ROUND_UP(skb->len, mss_now)
    BUG_ON(!tso_segs)
Add check for the minimum value of gso_max_size and gso_ipv4_max_size.

Fixes: 46e6b992c250 ("rtnetlink: allow GSO maximums to be set on device creation")
Fixes: 9eefedd58ae1 ("net: add gso_ipv4_max_size and gro_ipv4_max_size per device")
Signed-off-by: Wang Liang <wangliang74@huawei.com>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Link: https://patch.msgid.link/20241023035213.517386-1-wangliang74@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/core/rtnetlink.c