]> www.infradead.org Git - users/hch/configfs.git/commit
spi: pxa2xx: Do not override dev->platform_data on probe
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Thu, 22 Aug 2024 11:30:53 +0000 (14:30 +0300)
committerMark Brown <broonie@kernel.org>
Thu, 22 Aug 2024 12:34:05 +0000 (13:34 +0100)
commit9a8fc292dd93b93db30e01c94c0da4c944852f28
tree643277a2541a9b48d53d5166170c207cc87d5e69
parent783bf5d09f86b9736605f3e01a3472e55ef98ff8
spi: pxa2xx: Do not override dev->platform_data on probe

The platform_data field may be supplied by legacy board code.
In other cases we override it, and module remove and probe cycle
will crash the kernel since it will carry a stale pointer.

Fix this by supplying a third argument to the pxa2xx_spi_probe()
and avoid overriding dev->platform_data.

Reported-by: Hao Ma <hao.ma@intel.com>
Fixes: cc160697a576 ("spi: pxa2xx: Convert PCI driver to use spi-pxa2xx code directly")
Fixes: 3d8f037fbcab ("spi: pxa2xx: Move platform driver to a separate file")
Fixes: 20ade9b9771c ("spi: pxa2xx: Extract pxa2xx_spi_platform_*() callbacks")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://patch.msgid.link/20240822113408.750831-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx-pci.c
drivers/spi/spi-pxa2xx-platform.c
drivers/spi/spi-pxa2xx.c
drivers/spi/spi-pxa2xx.h