]> www.infradead.org Git - users/hch/misc.git/commit
block/fs: Pass an iocb to generic_atomic_write_valid()
authorJohn Garry <john.g.garry@oracle.com>
Sat, 19 Oct 2024 12:51:06 +0000 (12:51 +0000)
committerJens Axboe <axboe@kernel.dk>
Sat, 19 Oct 2024 22:48:21 +0000 (16:48 -0600)
commit9a8dbdadae509e5717ff6e5aa572ca0974d2101d
tree7266ec84c3309756d5627e519da531102d43fa89
parent9852d85ec9d492ebef56dc5f229416c925758edc
block/fs: Pass an iocb to generic_atomic_write_valid()

Darrick and Hannes both thought it better that generic_atomic_write_valid()
should be passed a struct iocb, and not just the member of that struct
which is referenced; see [0] and [1].

I think that makes a more generic and clean API, so make that change.

[0] https://lore.kernel.org/linux-block/680ce641-729b-4150-b875-531a98657682@suse.de/
[1] https://lore.kernel.org/linux-xfs/20240620212401.GA3058325@frogsfrogsfrogs/

Fixes: c34fc6f26ab8 ("fs: Initial atomic write support")
Suggested-by: Darrick J. Wong <djwong@kernel.org>
Suggested-by: Hannes Reinecke <hare@suse.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: John Garry <john.g.garry@oracle.com>
Link: https://lore.kernel.org/r/20241019125113.369994-2-john.g.garry@oracle.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/fops.c
fs/read_write.c
include/linux/fs.h