]> www.infradead.org Git - users/dwmw2/linux.git/commit
net: rose: fix netdev reference changes
authorEric Dumazet <edumazet@google.com>
Fri, 29 Jul 2022 09:12:32 +0000 (09:12 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 21 Aug 2022 13:15:51 +0000 (15:15 +0200)
commit9a070a4417660f0a2d01ee85a9914b342b0a7af8
tree5d932f50021741bfc0d85abdaeb211e09813b4fa
parent397e52dec16839b1296a350d8a34f898f284e061
net: rose: fix netdev reference changes

[ Upstream commit 931027820e4dafabc78aff82af59f8c1c4bd3128 ]

Bernard reported that trying to unload rose module would lead
to infamous messages:

unregistered_netdevice: waiting for rose0 to become free. Usage count = xx

This patch solves the issue, by making sure each socket referring to
a netdevice holds a reference count on it, and properly releases it
in rose_release().

rose_dev_first() is also fixed to take a device reference
before leaving the rcu_read_locked section.

Following patch will add ref_tracker annotations to ease
future bug hunting.

Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Reported-by: Bernard Pidoux <f6bvp@free.fr>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Tested-by: Bernard Pidoux <f6bvp@free.fr>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/rose/af_rose.c
net/rose/rose_route.c