]> www.infradead.org Git - users/jedix/linux-maple.git/commit
perf maps: Introduce map__set_kmap_maps() for kernel maps
authorArnaldo Carvalho de Melo <acme@redhat.com>
Fri, 28 Feb 2025 21:17:29 +0000 (18:17 -0300)
committerNamhyung Kim <namhyung@kernel.org>
Thu, 6 Mar 2025 07:03:04 +0000 (23:03 -0800)
commit99deaf5578cd768fa76363a598f6865fa6ecc891
tree2ec4d11d3460945373e2478b9a4a6d9373c77e5c
parent74fb903b212925ca47c0d1bc3d37b320a22b6264
perf maps: Introduce map__set_kmap_maps() for kernel maps

We need to set it in other places than __maps__insert(), so that we can
have access to the 'struct maps' from a kernel 'struct map'.

When building perf with 'DEBUG=1' we can notice it failing a consistency
check done in the check_invariants() function:

  root@number:~# perf record -- perf test -w offcpu
  [ perf record: Woken up 1 times to write data ]
  [ perf record: Captured and wrote 0.040 MB perf.data (23 samples) ]
  perf: util/maps.c:95: check_invariants: Assertion `map__end(prev) <= map__end(map)' failed.
  Aborted (core dumped)
  root@number:~#

The investigation on that was happening bisected to 876e80cf83d10585
("perf tools: Fixup end address of modules"), and the following patches
will plug the problems found, this patch is just legwork on that
direction.

Use the map__set_kmap_maps() name as per a review comment from Ian
Rogers, later there are further suggestions from him on getting rid of
the kmaps variable, see the thread referenced in the Link below.

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/lkml/Z74V0hZXrTLM6VIJ@x1
Link: https://lore.kernel.org/r/20250228211734.33781-2-acme@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/util/maps.c