]> www.infradead.org Git - users/jedix/linux-maple.git/commit
hwmon: (ltc2991) re-order conditions to fix off by one bug
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 4 Jul 2024 15:18:59 +0000 (10:18 -0500)
committerGuenter Roeck <linux@roeck-us.net>
Fri, 5 Jul 2024 01:14:50 +0000 (18:14 -0700)
commit99bf7c2eccff82760fa23ce967cc67c8c219c6a6
treed47e4d19d57b0a14ba979febe4ed62c277532404
parentcd228e7b65d43c441964a17f02c92f33d2c4af7b
hwmon: (ltc2991) re-order conditions to fix off by one bug

LTC2991_T_INT_CH_NR is 4.  The st->temp_en[] array has LTC2991_MAX_CHANNEL
(4) elements.  Thus if "channel" is equal to LTC2991_T_INT_CH_NR then we
have read one element beyond the end of the array.  Flip the conditions
around so that we check if "channel" is valid before using it as an array
index.

Fixes: 2b9ea4262ae9 ("hwmon: Add driver for ltc2991")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/Zoa9Y_UMY4_ROfhF@stanley.mountain
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/hwmon/ltc2991.c