]> www.infradead.org Git - users/jedix/linux-maple.git/commit
remoteproc: k3-r5: Drop check performed in k3_r5_rproc_{mbox_callback/kick}
authorSiddharth Vadapalli <s-vadapalli@ti.com>
Tue, 13 May 2025 05:44:35 +0000 (11:14 +0530)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Tue, 20 May 2025 17:02:16 +0000 (11:02 -0600)
commit9995dbfc2235efabdb3759606d522e1a7ec3bdcb
tree4a5bd5591f2ebb41afd6d11989e45d9127f1c9ce
parent46f7676c81533545f7e8e82e58880603f984cf0f
remoteproc: k3-r5: Drop check performed in k3_r5_rproc_{mbox_callback/kick}

Commit f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during
probe routine") introduced a check in the "k3_r5_rproc_mbox_callback()"
and "k3_r5_rproc_kick()" callbacks, causing them to exit if the remote
core's state is "RPROC_DETACHED". However, the "__rproc_attach()"
function that is responsible for attaching to a remote core, updates
the state of the remote core to "RPROC_ATTACHED" only after invoking
"rproc_start_subdevices()".

The "rproc_start_subdevices()" function triggers the probe of the Virtio
RPMsg devices associated with the remote core, which require that the
"k3_r5_rproc_kick()" and "k3_r5_rproc_mbox_callback()" callbacks are
functional. Hence, drop the check in the callbacks.

Fixes: f3f11cfe8907 ("remoteproc: k3-r5: Acquire mailbox handle during probe routine")
Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
Signed-off-by: Beleswar Padhi <b-padhi@ti.com>
Tested-by: Judith Mendez <jm@ti.com>
Reviewed-by: Andrew Davis <afd@ti.com>
Link: https://lore.kernel.org/r/20250513054510.3439842-2-b-padhi@ti.com
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/ti_k3_r5_remoteproc.c