]> www.infradead.org Git - users/dwmw2/qemu.git/commit
ne2000: fix possible out of bound access in ne2000_receive
authorJason Wang <jasowang@redhat.com>
Wed, 30 May 2018 05:08:15 +0000 (13:08 +0800)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Wed, 27 Mar 2019 05:53:12 +0000 (00:53 -0500)
commit9971a3fb90e06dace4c29a71a94b7a27bb6549e1
treeb91fc204142d5dc21d9369d65af6e40eaef13f26
parentb05db67c98c5194285efed0d647579ec78ac6499
ne2000: fix possible out of bound access in ne2000_receive

In ne2000_receive(), we try to assign size_ to size which converts
from size_t to integer. This will cause troubles when size_ is greater
INT_MAX, this will lead a negative value in size and it can then pass
the check of size < MIN_BUF_SIZE which may lead out of bound access of
for both buf and buf1.

Fixing by converting the type of size to size_t.

CC: qemu-stable@nongnu.org
Reported-by: Daniel Shapira <daniel@twistlock.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
(cherry picked from commit fdc89e90fac40c5ca2686733df17b6423fb8d8fb)
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
hw/net/ne2000.c