]> www.infradead.org Git - users/jedix/linux-maple.git/commit
wifi: wlcore: fix unbalanced pm_runtime calls
authorAndreas Kemnade <andreas@kemnade.info>
Sat, 4 Jan 2025 19:55:07 +0000 (20:55 +0100)
committerKalle Valo <kvalo@kernel.org>
Fri, 10 Jan 2025 12:51:26 +0000 (14:51 +0200)
commit996c934c8c196144af386c4385f61fcd5349af28
tree71ce840913630e2b849a5d81ac92901310d43162
parent1be94490b6b8a06ff14cd23fda8714e6ec37cdfb
wifi: wlcore: fix unbalanced pm_runtime calls

If firmware boot failes, runtime pm is put too often:
[12092.708099] wlcore: ERROR firmware boot failed despite 3 retries
[12092.708099] wl18xx_driver wl18xx.1.auto: Runtime PM usage count underflow!
Fix that by redirecting all error gotos before runtime_get so that runtime is
not put.

Fixes: c40aad28a3cf ("wlcore: Make sure firmware is initialized in wl1271_op_add_interface()")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Reviewed-by: Michael Nemanov <michael.nemanov@ti.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://patch.msgid.link/20250104195507.402673-1-akemnade@kernel.org
drivers/net/wireless/ti/wlcore/main.c