]> www.infradead.org Git - users/hch/misc.git/commit
x86/early_printk: Use 'mmio32' for consistency, fix comments
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 7 Apr 2025 17:22:14 +0000 (20:22 +0300)
committerIngo Molnar <mingo@kernel.org>
Wed, 9 Apr 2025 10:27:08 +0000 (12:27 +0200)
commit996457176bb7c64b3d30996592c754205ec4d3ea
treeb7bb150634f1f026c6681a3c96c98e26defef90e
parent45c2e30bbd64d75559b99f3a5c455129a7a34b06
x86/early_printk: Use 'mmio32' for consistency, fix comments

First of all, using 'mmio' prevents proper implementation of 8-bit accessors.
Second, it's simply inconsistent with uart8250 set of options. Rename it to
'mmio32'. While at it, remove rather misleading comment in the documentation.
From now on mmio32 is self-explanatory and pciserial supports not only 32-bit
MMIO accessors.

Also, while at it, fix the comment for the "pciserial" case. The comment
seems to be a copy'n'paste error when mentioning "serial" instead of
"pciserial" (with double quotes). Fix this.

With that, move it upper, so we don't calculate 'buf' twice.

Fixes: 3181424aeac2 ("x86/early_printk: Add support for MMIO-based UARTs")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Denis Mukhin <dmukhin@ford.com>
Link: https://lore.kernel.org/r/20250407172214.792745-1-andriy.shevchenko@linux.intel.com
Documentation/admin-guide/kernel-parameters.txt
arch/x86/kernel/early_printk.c