]> www.infradead.org Git - users/jedix/linux-maple.git/commit
firmware: qcom: scm: Mark get_wq_ctx() as atomic call
authorMurali Nalajala <quic_mnalajal@quicinc.com>
Wed, 14 Aug 2024 22:32:44 +0000 (15:32 -0700)
committerBjorn Andersson <andersson@kernel.org>
Thu, 15 Aug 2024 03:08:28 +0000 (22:08 -0500)
commit9960085a3a82c58d3323c1c20b991db6045063b0
treee2518c7de496aa8825291fa073a22492fd30a3c8
parentfce6a1eefb2a1db706fa17ca21e3e7107811d2e8
firmware: qcom: scm: Mark get_wq_ctx() as atomic call

Currently get_wq_ctx() is wrongly configured as a standard call. When two
SMC calls are in sleep and one SMC wakes up, it calls get_wq_ctx() to
resume the corresponding sleeping thread. But if get_wq_ctx() is
interrupted, goes to sleep and another SMC call is waiting to be allocated
a waitq context, it leads to a deadlock.

To avoid this get_wq_ctx() must be an atomic call and can't be a standard
SMC call. Hence mark get_wq_ctx() as a fast call.

Fixes: 6bf325992236 ("firmware: qcom: scm: Add wait-queue handling logic")
Cc: stable@vger.kernel.org
Signed-off-by: Murali Nalajala <quic_mnalajal@quicinc.com>
Signed-off-by: Unnathi Chalicheemala <quic_uchalich@quicinc.com>
Reviewed-by: Elliot Berman <quic_eberman@quicinc.com>
Link: https://lore.kernel.org/r/20240814223244.40081-1-quic_uchalich@quicinc.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/firmware/qcom/qcom_scm-smc.c