]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs
authorJason-JH.Lin <jason-jh.lin@mediatek.com>
Wed, 9 Oct 2024 03:46:42 +0000 (11:46 +0800)
committerChun-Kuang Hu <chunkuang.hu@kernel.org>
Tue, 22 Oct 2024 12:41:35 +0000 (12:41 +0000)
commit995d4d558eea79f8d2e8e46d0914c3940b7463ac
treedc753b73205c40c74364c8f7957c6502ac9ae51e
parent9852d85ec9d492ebef56dc5f229416c925758edc
drm/mediatek: ovl: Fix XRGB format breakage for blend_modes unsupported SoCs

OVL_CON_AEN is for alpha blending enable.
For the SoC that is supported the blend_modes, OVL_CON_AEN will always
enabled to use constant alpha and then use the ignore_pixel_alpha bit
to do the alpha blending for XRGB8888 format.
Note that ignore pixel alpha bit is not supported if the SoC is not
supported the blend_modes.
So it will break the original setting of XRGB8888 format for the
blend_modes unsupported SoCs, such as MT8173.

To fix the downgrade issue, enable alpha blending only when a valid
blend_mode or has_alpha is set.

Fixes: bc46eb5d5d77 ("drm/mediatek: Support DRM plane alpha in OVL")
Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
Reviewed-by: CK Hu <ck.hu@mediatek.com>
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
Link: https://patchwork.kernel.org/project/dri-devel/patch/20241009034646.13143-2-jason-jh.lin@mediatek.com/
Signed-off-by: Chun-Kuang Hu <chunkuang.hu@kernel.org>
drivers/gpu/drm/mediatek/mtk_disp_ovl.c