]> www.infradead.org Git - users/dwmw2/linux.git/commit
usermodehelper: check subprocess_info->path != NULL
authorOleg Nesterov <oleg@redhat.com>
Thu, 16 May 2013 15:43:55 +0000 (17:43 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 19 May 2013 18:38:45 +0000 (11:38 -0700)
commit98b17e9decaf1b103e4d0dd9ded21188c63dd475
tree3f59ab2f81e46e0c0241b1114923333ef7a5ab57
parente48c45d58f425fe3ff5a0e8a7584121682643096
usermodehelper: check subprocess_info->path != NULL

commit 264b83c07a84223f0efd0d1db9ccc66d6f88288f upstream.

argv_split(empty_or_all_spaces) happily succeeds, it simply returns
argc == 0 and argv[0] == NULL. Change call_usermodehelper_exec() to
check sub_info->path != NULL to avoid the crash.

This is the minimal fix, todo:

 - perhaps we should change argv_split() to return NULL or change the
   callers.

 - kill or justify ->path[0] check

 - narrow the scope of helper_lock()

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Acked-By: Lucas De Marchi <lucas.demarchi@intel.com>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
kernel/kmod.c