]> www.infradead.org Git - users/jedix/linux-maple.git/commit
irqchip/irq-mvebu-icu: Fix access to msi_data from irq_domain::host_data
authorStefan Eichenberger <eichest@gmail.com>
Fri, 24 Jan 2025 08:50:39 +0000 (09:50 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Mon, 27 Jan 2025 10:07:03 +0000 (11:07 +0100)
commit987f379b54091cc1b1db986bde71cee1081350b3
tree1b15ad4e55619e0632c55bde59a607d71a5e726c
parent825c78e6a60c309a59d18d5ac5968aa79cef0bd6
irqchip/irq-mvebu-icu: Fix access to msi_data from irq_domain::host_data

mvebu_icu_translate() incorrectly casts irq_domain::host_data directly to
mvebu_icu_msi_data. However, host_data actually points to a structure of
type msi_domain_info.

This incorrect cast causes issues such as the thermal sensors of the
CP110 platform malfunctioning. Specifically, the translation of the SEI
interrupt to IRQ_TYPE_EDGE_RISING fails, preventing proper interrupt
handling. The following error was observed:

  genirq: Setting trigger mode 4 for irq 85 failed (irq_chip_set_type_parent+0x0/0x34)
  armada_thermal f2400000.system-controller:thermal-sensor@70: Cannot request threaded IRQ 85

Resolve the issue by first casting host_data to msi_domain_info and then
accessing mvebu_icu_msi_data through msi_domain_info::chip_data.

Fixes: d929e4db22b6 ("irqchip/irq-mvebu-icu: Prepare for real per device MSI")
Signed-off-by: Stefan Eichenberger <eichest@gmail.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/all/20250124085140.44792-1-eichest@gmail.com
drivers/irqchip/irq-mvebu-icu.c