]> www.infradead.org Git - users/willy/pagecache.git/commit
power: supply: axp20x_battery: Fix fault handling for AXP717
authorChris Morgan <macromorgan@hotmail.com>
Fri, 31 Jan 2025 23:14:51 +0000 (17:14 -0600)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Mon, 3 Feb 2025 11:41:18 +0000 (12:41 +0100)
commit98380110bd48fbfd6a798ee11fffff893d36062c
treec02f397e7c76c0757046ab1ce11a5389e1968b29
parent64dd6edfc421479e416301c48b79cece8d0351fc
power: supply: axp20x_battery: Fix fault handling for AXP717

Correct the fault handling for the AXP717 by changing the i2c write
from regmap_update_bits() to regmap_write_bits(). The update bits
function does not work properly on a RW1C register where we must
write a 1 back to an existing register to clear it.

Additionally, as part of this testing I confirmed the behavior of
errors reappearing, so remove comment about assumptions.

Fixes: 6625767049c2 ("power: supply: axp20x_battery: add support for AXP717")
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
Reviewed-by: Chen-Yu Tsai <wens@csie.org>
Link: https://lore.kernel.org/r/20250131231455.153447-2-macroalpha82@gmail.com
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/axp20x_battery.c