]> www.infradead.org Git - users/jedix/linux-maple.git/commit
netfs: Fix ref leak on inserted extra subreq in write retry
authorDavid Howells <dhowells@redhat.com>
Tue, 1 Jul 2025 16:38:40 +0000 (17:38 +0100)
committerChristian Brauner <brauner@kernel.org>
Tue, 1 Jul 2025 20:37:13 +0000 (22:37 +0200)
commit97d8e8e52cb8ab3d7675880a92626d9a4332f7a6
tree4e3843b7e6287067443a5b4a049ad12ccd1e3ad3
parent09623e3a14c1c5465124350cd227457c2b0fb017
netfs: Fix ref leak on inserted extra subreq in write retry

The write-retry algorithm will insert extra subrequests into the list if it
can't get sufficient capacity to split the range that needs to be retried
into the sequence of subrequests it currently has (for instance, if the
cifs credit pool has fewer credits available than it did when the range was
originally divided).

However, the allocator furnishes each new subreq with 2 refs and then
another is added for resubmission, causing one to be leaked.

Fix this by replacing the ref-getting line with a neutral trace line.

Fixes: 288ace2f57c9 ("netfs: New writeback implementation")
Signed-off-by: David Howells <dhowells@redhat.com>
Link: https://lore.kernel.org/20250701163852.2171681-6-dhowells@redhat.com
Tested-by: Steve French <sfrench@samba.org>
Reviewed-by: Paulo Alcantara <pc@manguebit.org>
cc: netfs@lists.linux.dev
cc: linux-fsdevel@vger.kernel.org
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/netfs/write_retry.c