]> www.infradead.org Git - users/hch/xfsprogs.git/commit
xfs_db: write command broken on 64 bit values
authorDave Chinner <dchinner@redhat.com>
Tue, 8 Jul 2014 00:31:36 +0000 (10:31 +1000)
committerDave Chinner <david@fromorbit.com>
Tue, 8 Jul 2014 00:31:36 +0000 (10:31 +1000)
commit97ada36338a25ca38e22c430e6ffe91e3d76edb6
treeab575ecec47e284298ddad020bc918e646edb525
parentb5f5c2d13f390d109c808118f571f7623983a621
xfs_db: write command broken on 64 bit values

convert_args() has problesm with 64 bit fields because it tries to
shift them by 64 bits. The result of doing so is undefined by the C
standard, and so results in the unexpected behaviour of the result
being being the original value unchanged rather than 0. Hence you
can't write 64 bit fields because the code thinks that all values
other than 0 are out of range.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Dave Chinner <david@fromorbit.com>
db/write.c