]> www.infradead.org Git - users/jedix/linux-maple.git/commit
HID: magicmouse: ignore 'ivalid report id' while switching modes, v2
authorJiri Kosina <jkosina@suse.cz>
Thu, 25 Aug 2011 12:21:37 +0000 (14:21 +0200)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Thu, 8 Dec 2011 19:17:04 +0000 (11:17 -0800)
commit976fb066148e0cec1382caee69a00aa7e51b3009
treee6ae95c62b64618fd1b512f82e4874cd444d45cf
parent6fc8d89d87c9d07db5855bc95cafb8b44c84ea3a
HID: magicmouse: ignore 'ivalid report id' while switching modes, v2

commit 35d851df23b093ee027f827fed2213ae5e88fc7a upstream.

This is basically a more generic respin of 23746a6 ("HID: magicmouse: ignore
'ivalid report id' while switching modes") which got reverted later by
c3a492.

It turns out that on some configurations, this is actually still the case
and we are not able to detect in runtime.

The device reponds with 'invalid report id' when feature report switching it
into multitouch mode is sent to it.

This has been silently ignored before 0825411ade ("HID: bt: Wait for ACK
on Sent Reports"), but since this commit, it propagates -EIO from the _raw
callback .

So let the driver ignore -EIO as response to 0xd7,0x01 report, as that's
how the device reacts in normal mode.

Sad, but following reality.

This fixes https://bugzilla.kernel.org/show_bug.cgi?id=35022

Reported-by: Chase Douglas <chase.douglas@canonical.com>
Reported-by: Jaikumar Ganesh <jaikumarg@android.com>
Tested-by: Chase Douglas <chase.douglas@canonical.com>
Tested-by: Jaikumar Ganesh <jaikumarg@android.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Cc: Josh Boyer <jwboyer@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/hid/hid-magicmouse.c