]> www.infradead.org Git - users/hch/misc.git/commit
ipv6: Fix memleak of nhc_pcpu_rth_output in fib_check_nh_v6_gw().
authorKuniyuki Iwashima <kuniyu@amazon.com>
Wed, 12 Mar 2025 01:03:25 +0000 (18:03 -0700)
committerPaolo Abeni <pabeni@redhat.com>
Tue, 18 Mar 2025 11:55:11 +0000 (12:55 +0100)
commit9740890ee20e01f99ff1dde84c63dcf089fabb98
treeb29b97c989d93f65915729137d2d7670a8778b84
parentd509d129be7a44a970a871ffd6f4d1abaae65bce
ipv6: Fix memleak of nhc_pcpu_rth_output in fib_check_nh_v6_gw().

fib_check_nh_v6_gw() expects that fib6_nh_init() cleans up everything
when it fails.

Commit 7dd73168e273 ("ipv6: Always allocate pcpu memory in a fib6_nh")
moved fib_nh_common_init() before alloc_percpu_gfp() within fib6_nh_init()
but forgot to add cleanup for fib6_nh->nh_common.nhc_pcpu_rth_output in
case it fails to allocate fib6_nh->rt6i_pcpu, resulting in memleak.

Let's call fib_nh_common_release() and clear nhc_pcpu_rth_output in the
error path.

Note that we can remove the fib6_nh_release() call in nh_create_ipv6()
later in net-next.git.

Fixes: 7dd73168e273 ("ipv6: Always allocate pcpu memory in a fib6_nh")
Signed-off-by: Kuniyuki Iwashima <kuniyu@amazon.com>
Link: https://patch.msgid.link/20250312010333.56001-1-kuniyu@amazon.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
net/ipv6/route.c