]> www.infradead.org Git - users/dwmw2/linux.git/commit
openvswitch: Avoid OOB read when parsing flow nlattrs
authorRoss Lagerwall <ross.lagerwall@citrix.com>
Mon, 14 Jan 2019 09:16:56 +0000 (09:16 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 31 Jan 2019 07:15:33 +0000 (08:15 +0100)
commit971bf1b09350b6ff343ec92c41d10cf3ff2aee45
treeda710be73f57f006d2b550564a2b0bb17157fd66
parent00258ab1cf041dda6df63c458da0f37bcdf684d0
openvswitch: Avoid OOB read when parsing flow nlattrs

[ Upstream commit 04a4af334b971814eedf4e4a413343ad3287d9a9 ]

For nested and variable attributes, the expected length of an attribute
is not known and marked by a negative number.  This results in an OOB
read when the expected length is later used to check if the attribute is
all zeros. Fix this by using the actual length of the attribute rather
than the expected length.

Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/openvswitch/flow_netlink.c