]> www.infradead.org Git - linux-platform-drivers-x86.git/commit
xen/gntdev: fix gntdev_mmap() error exit path
authorJuergen Gross <jgross@suse.com>
Fri, 23 Apr 2021 05:40:38 +0000 (07:40 +0200)
committerJuergen Gross <jgross@suse.com>
Mon, 10 May 2021 07:32:00 +0000 (09:32 +0200)
commit970655aa9b42461f8394e4457307005bdeee14d9
tree3181bb4b00415833f5f2d3c39548bbd3189910d2
parent6efb943b8616ec53a5e444193dccf1af9ad627b5
xen/gntdev: fix gntdev_mmap() error exit path

Commit d3eeb1d77c5d0af ("xen/gntdev: use mmu_interval_notifier_insert")
introduced an error in gntdev_mmap(): in case the call of
mmu_interval_notifier_insert_locked() fails the exit path should not
call mmu_interval_notifier_remove(), as this might result in NULL
dereferences.

One reason for failure is e.g. a signal pending for the running
process.

Fixes: d3eeb1d77c5d0af ("xen/gntdev: use mmu_interval_notifier_insert")
Cc: stable@vger.kernel.org
Reported-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Tested-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
Signed-off-by: Juergen Gross <jgross@suse.com>
Reviewed-by: Luca Fancellu <luca.fancellu@arm.com>
Link: https://lore.kernel.org/r/20210423054038.26696-1-jgross@suse.com
Signed-off-by: Juergen Gross <jgross@suse.com>
drivers/xen/gntdev.c