]> www.infradead.org Git - users/willy/pagecache.git/commit
gpiolib: don't bail out if get_direction() fails in gpiochip_add_data()
authorBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Wed, 19 Feb 2025 14:43:56 +0000 (15:43 +0100)
committerBartosz Golaszewski <bartosz.golaszewski@linaro.org>
Thu, 20 Feb 2025 13:08:18 +0000 (14:08 +0100)
commit96fa9ec477ff60bed87e1441fd43e003179f3253
tree98ab616fdc0edf11d2f6b921ee03aa41a7750ded
parent81570d6a7ad37033c7895811551a5a9023706eda
gpiolib: don't bail out if get_direction() fails in gpiochip_add_data()

Since commit 9d846b1aebbe ("gpiolib: check the return value of
gpio_chip::get_direction()") we check the return value of the
get_direction() callback as per its API contract. Some drivers have been
observed to fail to register now as they may call get_direction() in
gpiochip_add_data() in contexts where it has always silently failed.
Until we audit all drivers, replace the bail-out to a kernel log
warning.

Fixes: 9d846b1aebbe ("gpiolib: check the return value of gpio_chip::get_direction()")
Reported-by: Mark Brown <broonie@kernel.org>
Closes: https://lore.kernel.org/all/Z7VFB1nST6lbmBIo@finisterre.sirena.org.uk/
Reported-by: Marek Szyprowski <m.szyprowski@samsung.com>
Closes: https://lore.kernel.org/all/dfe03f88-407e-4ef1-ad30-42db53bbd4e4@samsung.com/
Tested-by: Mark Brown <broonie@kernel.org>
Reviewed-by: Mark Brown <broonie@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20250219144356.258635-1-brgl@bgdev.pl
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
drivers/gpio/gpiolib.c