]> www.infradead.org Git - users/jedix/linux-maple.git/commit
x86/of: Don't use DTB for SMP setup if ACPI is enabled
authorDmytro Maluka <dmaluka@chromium.org>
Sun, 5 Jan 2025 17:27:40 +0000 (17:27 +0000)
committerIngo Molnar <mingo@kernel.org>
Tue, 25 Feb 2025 21:13:02 +0000 (22:13 +0100)
commit96f41f644c4885761b0d117fc36dc5dcf92e15ec
tree19eda662bec46c4c5540ec941e10090c36b0e21c
parentd082ecbc71e9e0bf49883ee4afd435a77a5101b6
x86/of: Don't use DTB for SMP setup if ACPI is enabled

There are cases when it is useful to use both ACPI and DTB provided by
the bootloader, however in such cases we should make sure to prevent
conflicts between the two. Namely, don't try to use DTB for SMP setup
if ACPI is enabled.

Precisely, this prevents at least:

- incorrectly calling register_lapic_address(APIC_DEFAULT_PHYS_BASE)
  after the LAPIC was already successfully enumerated via ACPI, causing
  noisy kernel warnings and probably potential real issues as well

- failed IOAPIC setup in the case when IOAPIC is enumerated via mptable
  instead of ACPI (e.g. with acpi=noirq), due to
  mpparse_parse_smp_config() overridden by x86_dtb_parse_smp_config()

Signed-off-by: Dmytro Maluka <dmaluka@chromium.org>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Link: https://lore.kernel.org/r/20250105172741.3476758-2-dmaluka@chromium.org
arch/x86/kernel/devicetree.c