]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ixgbe: do not call check_link for ethtool in ixgbe_get_settings()
authorEmil Tantilov <emil.s.tantilov@intel.com>
Thu, 3 Dec 2015 23:20:06 +0000 (15:20 -0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Wed, 6 Jul 2016 23:40:46 +0000 (16:40 -0700)
commit96ea19c4d10cfaf0ea9b5de3f98d4a33acd114ff
tree2321086ce2919c35f033db6219eb8c0f0c773a66
parent6ee5c76646c7660626889b9c034f8e726d85d7e8
ixgbe: do not call check_link for ethtool in ixgbe_get_settings()

Orabug: 23177316

In ixgbe_get_settings() the link status and speed of the interface
are determined based on a read from the LINKS register via the call
to mac.ops.check.link(). This can cause issues where external drivers
may end up with unknown speed when calling ethtool_get_setings().

Instead of calling the mac.ops.check_link() we can report the speed
from the adapter structure which is populated by the driver.

Signed-off-by: Emil Tantilov <emil.s.tantilov@intel.com>
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
(cherry picked from commit 0e4d422f5f7249324ac8d1b8e12772e530787a66)
Signed-off-by: Brian Maly <brian.maly@oracle.com>
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c