]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fm10k: correctly pack TLV structures and explain reasoning
authorJacob Keller <jacob.e.keller@intel.com>
Mon, 9 Nov 2015 22:04:08 +0000 (14:04 -0800)
committerChuck Anderson <chuck.anderson@oracle.com>
Sun, 26 Feb 2017 06:03:43 +0000 (22:03 -0800)
commit9686b4b555484e8537e475ec467d99a3a7b5840e
treeba7b43538186870812454029578ea89a6151d461
parent1f8e7caf8cff460d3f5ce048337f358a9b8dfdff
fm10k: correctly pack TLV structures and explain reasoning

The TLV format for little endian structures is actually 4 byte aligned
copy. To this end, we need to add an additional __aligned(4) marker
along with __packed to ensure that these structures are actually 4 byte
aligned and packed correctly. Use of just __packed will not work as this
will result in 1byte alignment which is incorrect. Add a comment
explaining the reasoning behind why these structures need the special
treatment.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Orabug: 25394529
(cherry picked from commit 8c2a029c7eff14510fed04cef2848c6d21ed92dd)
Signed-off-by: Jack Vogel <jack.vogel@oracle.com>
drivers/net/ethernet/intel/fm10k/fm10k_pf.h