]> www.infradead.org Git - users/jedix/linux-maple.git/commit
ppp: use IFF_NO_QUEUE in virtual interfaces
authorQingfang Deng <dqfext@gmail.com>
Sat, 1 Mar 2025 13:55:16 +0000 (21:55 +0800)
committerJakub Kicinski <kuba@kernel.org>
Wed, 5 Mar 2025 01:11:17 +0000 (17:11 -0800)
commit95d0d094ba26432ec467e2260f4bf553053f1f8f
tree7c3aae6663bbf9ee26d1830ac623483488b86046
parent00d66b5fcd4f9d1d8419b7c418575d1f2cd91cb5
ppp: use IFF_NO_QUEUE in virtual interfaces

For PPPoE, PPTP, and PPPoL2TP, the start_xmit() function directly
forwards packets to the underlying network stack and never returns
anything other than 1. So these interfaces do not require a qdisc,
and the IFF_NO_QUEUE flag should be set.

Introduces a direct_xmit flag in struct ppp_channel to indicate when
IFF_NO_QUEUE should be applied. The flag is set in ppp_connect_channel()
for relevant protocols.

While at it, remove the usused latency member from struct ppp_channel.

Signed-off-by: Qingfang Deng <dqfext@gmail.com>
Reviewed-by: Toke Høiland-Jørgensen <toke@redhat.com>
Link: https://patch.msgid.link/20250301135517.695809-1-dqfext@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ppp/ppp_generic.c
drivers/net/ppp/pppoe.c
drivers/net/ppp/pptp.c
include/linux/ppp_channel.h
net/l2tp/l2tp_ppp.c