]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drm/panel: ili9882t: Don't use a table for initting panels
authorDouglas Anderson <dianders@chromium.org>
Tue, 14 May 2024 17:20:58 +0000 (10:20 -0700)
committerNeil Armstrong <neil.armstrong@linaro.org>
Wed, 15 May 2024 20:59:16 +0000 (22:59 +0200)
commit95951654ca57786c658942a7c6f4471ef3f0d47e
tree2d7b79d68899785a80abbeb9df117db7f5e1045d
parentd6ddb6624a7fc4fc3d7750bccaf43c66b55beab9
drm/panel: ili9882t: Don't use a table for initting panels

Consensus on the mailing lists is that panels shouldn't use a table of
init commands but should instead use init functions. With the recently
introduced mipi_dsi_dcs_write_seq_multi() this is not only clean/easy
but also saves space. Measuring before/after this change:

$ scripts/bloat-o-meter \
  .../before/panel-ilitek-ili9882t.ko \
  .../after/panel-ilitek-ili9882t.ko
add/remove: 3/2 grow/shrink: 0/2 up/down: 6834/-8177 (-1343)
Function                                     old     new   delta
starry_ili9882t_init                           -    6152   +6152
starry_ili9882t_init.d                         -     678    +678
ili9882t_disable.d                             -       4      +4
ili9882t_disable                             260     228     -32
ili9882t_prepare                             540     396    -144
.compoundliteral                             681       -    -681
starry_ili9882t_init_cmd                    7320       -   -7320
Total: Before=11928, After=10585, chg -11.26%

Let's do the conversion.

Since we're touching all the tables, let's also convert hex numbers to
lower case as per kernel conventions.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://lore.kernel.org/r/20240514102056.v5.8.I407b977f9508573103491df549dfaffc3688db13@changeid
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240514102056.v5.8.I407b977f9508573103491df549dfaffc3688db13@changeid
drivers/gpu/drm/panel/panel-ilitek-ili9882t.c