]> www.infradead.org Git - users/jedix/linux-maple.git/commit
fsdax: remove zeroing code from dax_unshare_iter
authorDarrick J. Wong <djwong@kernel.org>
Thu, 3 Oct 2024 15:09:32 +0000 (08:09 -0700)
committerChristian Brauner <brauner@kernel.org>
Mon, 7 Oct 2024 11:51:47 +0000 (13:51 +0200)
commit95472274b6fed8f2d30fbdda304e12174b3d4099
treebaef0f83a6c5a896d1c3bb875592bcf86f4cf166
parent6ef6a0e821d3dad6bf8a5d5508762dba9042c84b
fsdax: remove zeroing code from dax_unshare_iter

Remove the code in dax_unshare_iter that zeroes the destination memory
because it's not necessary.

If srcmap is unwritten, we don't have to do anything because that
unwritten extent came from the regular file mapping, and unwritten
extents cannot be shared.  The same applies to holes.

Furthermore, zeroing to unshare a mapping is just plain wrong because
unsharing means copy on write, and we should be copying data.

This is effectively a revert of commit 13dd4e04625f ("fsdax: unshare:
zero destination if srcmap is HOLE or UNWRITTEN")

Cc: ruansy.fnst@fujitsu.com
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
Link: https://lore.kernel.org/r/172796813311.1131942.16033376284752798632.stgit@frogsfrogsfrogs
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/dax.c