]> www.infradead.org Git - users/jedix/linux-maple.git/commit
drivers: staging: r8188eu: Fix sleep-in-atomic-context bug in rtw_join_timeout_handler
authorDuoming Zhou <duoming@zju.edu.cn>
Tue, 18 Oct 2022 08:34:24 +0000 (16:34 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 31 Dec 2022 12:32:38 +0000 (13:32 +0100)
commit9494faf74f8dcd9368d1aff9f44503c6ec2adf2d
treed9cd3a8e7dc051d95e6bae05df9ca462f20447da
parent3d97c13a1152b4e7e50673d7648f3f69b9839b03
drivers: staging: r8188eu: Fix sleep-in-atomic-context bug in rtw_join_timeout_handler

[ Upstream commit ce8cc75c7419ad54cb99437543a54c97c7446db5 ]

The rtw_join_timeout_handler() is a timer handler that
runs in atomic context, but it could call msleep().
As a result, the sleep-in-atomic-context bug will happen.
The process is shown below:

     (atomic context)
rtw_join_timeout_handler
 _rtw_join_timeout_handler
  rtw_do_join
   rtw_select_and_join_from_scanned_queue
    rtw_indicate_disconnect
     rtw_lps_ctrl_wk_cmd
      lps_ctrl_wk_hdl
       LPS_Leave
        LPS_RF_ON_check
         msleep //sleep in atomic context

Fix by removing msleep() and replacing with mdelay().

Fixes: 15865124feed ("staging: r8188eu: introduce new core dir for RTL8188eu driver")
Signed-off-by: Duoming Zhou <duoming@zju.edu.cn>
Link: https://lore.kernel.org/r/20221018083424.79741-1-duoming@zju.edu.cn
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/staging/r8188eu/core/rtw_pwrctrl.c