]> www.infradead.org Git - users/jedix/linux-maple.git/commit
powercap: call put_device() on an error path in powercap_register_control_type()
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Fri, 10 Jan 2025 01:05:54 +0000 (10:05 +0900)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Thu, 23 Jan 2025 20:28:18 +0000 (21:28 +0100)
commit93c66fbc280747ea700bd6199633d661e3c819b3
treebd41a339b3bf551e6635ece27e19fefb5c250a47
parentf4b9d3bf44d59ca4489bd8c489539c27c02e5c6a
powercap: call put_device() on an error path in powercap_register_control_type()

powercap_register_control_type() calls device_register(), but does not
release the refcount of the device when it fails.

Call put_device() before returning an error to balance the refcount.

Since the kfree(control_type) will be done by powercap_release(), remove
the lines in powercap_register_control_type() before returning the error.

This bug was found by an experimental verifier that I am developing.

Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://patch.msgid.link/20250110010554.1583411-1-joe@pf.is.s.u-tokyo.ac.jp
[ rjw: Changelog edits ]
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/powercap/powercap_sys.c