]> www.infradead.org Git - users/jedix/linux-maple.git/commit
tools lib traceevent: Do not reassign parg after collapse_tree()
authorSteven Rostedt <rostedt@goodmis.org>
Wed, 11 May 2016 19:09:36 +0000 (15:09 -0400)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:21:52 +0000 (17:21 -0500)
commit932f1f6b290b17344db875ec607a23aa2fadce48
tree035d4ec29eeca146604f4525e487947808462366
parent44002208a5d305b6f9ae407b73e8bdf74c939463
tools lib traceevent: Do not reassign parg after collapse_tree()

Orabug: 25227153

[ Upstream commit 106b816cb46ebd87408b4ed99a2e16203114daa6 ]

At the end of process_filter(), collapse_tree() was changed to update
the parg parameter, but the reassignment after the call wasn't removed.

What happens is that the "current_op" gets modified and freed and parg
is assigned to the new allocated argument. But after the call to
collapse_tree(), parg is assigned again to the just freed "current_op",
and this causes the tool to crash.

The current_op variable must also be assigned to NULL in case of error,
otherwise it will cause it to be free()ed twice.

Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Cc: stable@vger.kernel.org # 3.14+
Fixes: 42d6194d133c ("tools lib traceevent: Refactor process_filter()")
Link: http://lkml.kernel.org/r/20160511150936.678c18a1@gandalf.local.home
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit 47348e3fcc9aeeb64d792d05c735b37b2c22fbac)

Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
tools/lib/traceevent/parse-filter.c