]> www.infradead.org Git - users/jedix/linux-maple.git/commit
TTY: drop driver reference in tty_open fail path
authorJiri Slaby <jslaby@suse.cz>
Wed, 12 Oct 2011 09:32:42 +0000 (11:32 +0200)
committerMaxim Uvarov <maxim.uvarov@oracle.com>
Thu, 8 Dec 2011 19:17:42 +0000 (11:17 -0800)
commit93204e3216ca371cf639e32a6165b61495d61aed
tree448b24fedd610181304f0c0a74c8f5a5a6e36948
parent4aad89b5da0eb2f679fdcc100f3a7d54c3278a1e
TTY: drop driver reference in tty_open fail path

commit c290f8358acaeffd8e0c551ddcc24d1206143376 upstream.

When tty_driver_lookup_tty fails in tty_open, we forget to drop a
reference to the tty driver. This was added by commit 4a2b5fddd5 (Move
tty lookup/reopen to caller).

Fix that by adding tty_driver_kref_put to the fail path.

I will refactor the code later. This is for the ease of backporting to
stable.

Introduced-in: v2.6.28-rc2
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Acked-by: Sukadev Bhattiprolu <sukadev@linux.vnet.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/tty/tty_io.c