]> www.infradead.org Git - users/jedix/linux-maple.git/commit
mm: split huge PUD on wp_huge_pud fallback
authorGowans, James <jgowans@amazon.com>
Thu, 23 Jun 2022 05:24:03 +0000 (05:24 +0000)
committerakpm <akpm@linux-foundation.org>
Sun, 26 Jun 2022 22:39:48 +0000 (15:39 -0700)
commit926c287b43d582e42b48aa088c8e34da9f877336
treebf7ae22895f28243fa6123641d5174dc1be6941a
parent6203e587d3f8e16d02b5f8644e05804eeedc9204
mm: split huge PUD on wp_huge_pud fallback

Currently the implementation will split the PUD when a fallback is taken
inside the create_huge_pud function.  This isn't where it should be done:
the splitting should be done in wp_huge_pud, just like it's done for PMDs.
Reason being that if a callback is taken during create, there is no PUD
yet so nothing to split, whereas if a fallback is taken when encountering
a write protection fault there is something to split.

It looks like this was the original intention with the commit where the
splitting was introduced, but somehow it got moved to the wrong place
between v1 and v2 of the patch series.  Rebase mistake perhaps.

Link: https://lkml.kernel.org/r/6f48d622eb8bce1ae5dd75327b0b73894a2ec407.camel@amazon.com
Fixes: 327e9fd48972 ("mm: Split huge pages on write-notify or COW")
Signed-off-by: James Gowans <jgowans@amazon.com>
Reviewed-by: Thomas Hellström <thomas.hellstrom@linux.intel.com>
Cc: Christian König <christian.koenig@amd.com>
Cc: Jan H. Schönherr <jschoenh@amazon.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/memory.c