]> www.infradead.org Git - users/jedix/linux-maple.git/commit
netlink: Fix dump skb leak/double free
authorHerbert Xu <herbert@gondor.apana.org.au>
Mon, 16 May 2016 09:28:16 +0000 (17:28 +0800)
committerDhaval Giani <dhaval.giani@oracle.com>
Fri, 20 Jan 2017 22:22:04 +0000 (17:22 -0500)
commit923609b109211d60bc4db614f6efa22ee08764bb
treecadd6fe115f77609afe09203bd70b3e8135c65c6
parentb6ba665c5ba5471b9ddddddef67934756fa781b6
netlink: Fix dump skb leak/double free

Orabug: 25308090

[ Upstream commit 92964c79b357efd980812c4de5c1fd2ec8bb5520 ]

When we free cb->skb after a dump, we do it after releasing the
lock.  This means that a new dump could have started in the time
being and we'll end up freeing their skb instead of ours.

This patch saves the skb and module before we unlock so we free
the right memory.

Fixes: 16b304f3404f ("netlink: Eliminate kmalloc in netlink dump operation.")
Reported-by: Baozeng Ding <sploving1@gmail.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Acked-by: Cong Wang <xiyou.wangcong@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
(cherry picked from commit e39cd93be0009ae4548a737756a947d2030956ab)
Signed-off-by: Dhaval Giani <dhaval.giani@oracle.com>
net/netlink/af_netlink.c