]> www.infradead.org Git - users/jedix/linux-maple.git/commit
octeontx2-af: Pass string literal as format argument of alloc_workqueue()
authorSimon Horman <horms@kernel.org>
Wed, 4 Sep 2024 18:29:36 +0000 (19:29 +0100)
committerJakub Kicinski <kuba@kernel.org>
Sat, 7 Sep 2024 01:23:49 +0000 (18:23 -0700)
commit92218f108f510ac66715a7700479acacb18335f5
treec00e836e2209f6fc55005c445cd98cb31273264f
parentcca0d69baf950e5a82c21d09917b4cc654c83fe9
octeontx2-af: Pass string literal as format argument of alloc_workqueue()

Recently I noticed that both gcc-14 and clang-18 report that passing
a non-string literal as the format argument of alloc_workqueue()
is potentially insecure.

E.g. clang-18 says:

.../rvu.c:2493:32: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
 2493 |         mw->mbox_wq = alloc_workqueue(name,
      |                                       ^~~~
.../rvu.c:2493:32: note: treat the string as an argument to avoid this
 2493 |         mw->mbox_wq = alloc_workqueue(name,
      |                                       ^
      |                                       "%s",

It is always the case where the contents of name is safe to pass as the
format argument. That is, in my understanding, it never contains any
format escape sequences.

But, it seems better to be safe than sorry. And, as a bonus, compiler
output becomes less verbose by addressing this issue as suggested by
clang-18.

Compile tested only by author.

Tested-by: Geetha sowjanya <gakula@marvell.com>
Signed-off-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240904-octeontx2-sparse-v2-1-14f2305fe4b2@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/octeontx2/af/rvu.c